Fix CI for node < 8 #2373
Closed
Fix CI for node < 8 #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kassens
referenced
this pull request
Mar 16, 2018
Reviewed By: arcanis Differential Revision: D7194524 fbshipit-source-id: 85b11b7319c6e0985b166ba9ce990a2581ff1dd2
|
Thanks! 👍 |
There was a problem hiding this comment.
@kassens is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @alloy for noticing that 0d24a72 broke CI. The reason is that node < 8 does not support trailing commas for function calls which prettier adds in our configuration. This should fix it.